Re: [PATCH v6 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter

[David Hildenbrand <david@xxxxxxxxxx>]

On 27.07.23 10:02, Aneesh Kumar K.V wrote:
> Acked-by: David Hildenbrand <david@xxxxxxxxxx>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx>
> ---
>   mm/memory_hotplug.c | 35 +++++++++++++++++++----------------
>   1 file changed, 19 insertions(+), 16 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index aa8724bd1d53..7c877756b363 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -89,7 +89,12 @@ static int set_memmap_mode(const char *val, const struct kernel_param *kp)
>   		else
>   			mode = MEMMAP_ON_MEMORY_DISABLE;
>   	}
> +	/*
> +	 * Avoid changing memmap mode during hotplug.
> +	 */

Nit: comment fits into a single line.

--
Cheers,

David / dhildenb