Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block

[David Hildenbrand <david@xxxxxxxxxx>]

> +	/*
> +	 * Now that we are tracking alloc and free correctly
> +	 * we can add check to verify altmap free pages.
> +	 */

Better remove the history lesson from the comment.

"Verify that all vmemmap pages have actually been freed."

> +	if (altmap) {
> +		WARN(altmap->alloc, "Altmap not fully unmapped");
> +		kfree(altmap);
> +	}
> +
>   	if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) {
>   		memblock_phys_free(start, size);
>   		memblock_remove(start, size);

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb