Re: [RFC] Common code 04/12] slabs: Extract common code for kmem_cache_create

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 May 2012, Glauber Costa wrote:

> On 05/18/2012 08:19 PM, Christoph Lameter wrote:
> > Index: linux-2.6/mm/slab.c
> > ===================================================================
> > --- linux-2.6.orig/mm/slab.c	2012-05-11 09:36:35.308445605 -0500
> > +++ linux-2.6/mm/slab.c	2012-05-11 09:43:33.160436947 -0500
> > @@ -1585,7 +1585,7 @@ void __init kmem_cache_init(void)
> >   	 * bug.
> >   	 */
> >
> > -	sizes[INDEX_AC].cs_cachep = kmem_cache_create(names[INDEX_AC].name,
> > +	sizes[INDEX_AC].cs_cachep = __kmem_cache_create(names[INDEX_AC].name,
> >   					sizes[INDEX_AC].cs_size,
> >   					ARCH_KMALLOC_MINALIGN,
> >   					ARCH_KMALLOC_FLAGS|SLAB_PANIC,
>
> So, before your patch, the kmalloc caches were getting all the sanity checking
> done. No we're skipping them. Any particular reason?

I can visually do the sanity checking since the parameters are all in the
source. No need to do these checks again at runtime.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]