On Thu, 17 May 2012 18:24:44 +0200 Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote: > On Thu, 2012-05-17 at 17:00 +0100, Catalin Marinas wrote: > > > BTW, looking at your tlb-unify branch, does tlb_remove_table() call > > tlb_flush/tlb_flush_mmu before freeing the tables? I can only see > > tlb_remove_page() doing this. On ARM, even UP, we need the TLB flushing > > after clearing the pmd and before freeing the pte page table (and > > ideally doing it less often than at every pte_free_tlb() call). > > No I don't think it does, so far the only archs using the RCU stuff are > ppc,sparc and s390 and none of those needed that (Xen might join them > soon though). But I will have to look and consider this more carefully. > I 'lost' most of the ppc/sparc/s390 details from memory to say this with > any certainty. s390 needs a TLB flush for the pgd, pud and pmd tables. See git commit cd94154cc6a28dd9dc271042c1a59c08d26da886 for the sad details. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>