On Thu 17-05-12 23:35:12, Peter Zijlstra wrote: > On Tue, 2012-05-15 at 17:43 +0200, Jan Kara wrote: > > + if (numerator > ((long long)denominator) * max_frac / 100) > > Does that even compile on 32bit archs? > > Operator precedence is *,/ left-to-right, so that's: > > long long t1 = (long long)denom * max_frac > long long t2 = t1 / 100; > > Which is a 64bit signed division. > > There's a reason I used that max_prop_frac thing you removed, it avoids > having to do the division at all and allows a mult and shift instead. Yeah, I misunderstood it's purpose when I read the code originally. I'll put it back to avoid the division since this is a hot path. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>