On Tue, May 16, 2023 at 11:20:07PM -0700, Christoph Hellwig wrote:
> On Sat, May 13, 2023 at 02:14:18PM +0100, Lorenzo Stoakes wrote:
> > > Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function")
> >
> > Not sure if this is really 'fixing' anything, I mean ostensibly, but not
> > sure if the tag is relevant here, that is more so for a bug being
> > introduced, and unless an issue has arisen not sure if it's
> > appropriate. But this might be a nit, again!
>
> vmap_pfn was factored out of i915-specific code, which probably never
> ran on anything but x86 at that time. Now that intel builds plug in
> GPUs is probably could. But independent of that core mm code should use
> the proper APIs.
>
Yeah indeed, I just wondered if the tag was quite right for this but it's not a
big deal, fine to leave in.
I agree the approach is correct, just wanted your ok so also adding my:-
Acked-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>
