Michael, You applied the vdpa patch without rebasing on net-next where the related mlx5_core is available: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git main I wonder though why the code is still not in Linus' tree. Moreover, I am waiting for Saeed to send out another mlx5_core patch (attached as 0001-net-mlx5_core-Modify-mlx5_msix_alloc-free-to-not-req.patch): After which I want to send the vdpa patch: 0002-vdpa-mlx5-Support-interrupt-bypassing.patch > -----Original Message----- > From: Michael S. Tsirkin <mst@xxxxxxxxxx> > Sent: Sunday, 23 April 2023 13:50 > To: Eli Cohen <elic@xxxxxxxxxx> > Cc: Dragos Tatulea <dtatulea@xxxxxxxxxx>; llvm@xxxxxxxxxxxxxxx; oe-kbuild- > all@xxxxxxxxxxxxxxx; Linux Memory Management List <linux-mm@xxxxxxxxx>; > Saeed Mahameed <saeedm@xxxxxxxxxx> > Subject: Re: [lkp@xxxxxxxxx: [linux-next:master 13449/13717] > drivers/vdpa/mlx5/net/mlx5_vnet.c:2896:3: error: implicit declaration of > function 'mlx5_msix_free' is invalid in C99] > > Sorry got confused. Referring to the robot warning here. > > On Sun, Apr 23, 2023 at 07:29:45AM +0000, Eli Cohen wrote: > > Are you referring to kernel robot warning or to updating MAINTAINERS? > > I was not the maintainer of anything so not sure what you mean here. > > > > > -----Original Message----- > > > From: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > Sent: Sunday, 23 April 2023 10:11 > > > To: Dragos Tatulea <dtatulea@xxxxxxxxxx>; Eli Cohen <elic@xxxxxxxxxx> > > > Cc: llvm@xxxxxxxxxxxxxxx; oe-kbuild-all@xxxxxxxxxxxxxxx; Linux Memory > > > Management List <linux-mm@xxxxxxxxx>; Michael S. Tsirkin > > > <mst@xxxxxxxxxx>; Saeed Mahameed <saeedm@xxxxxxxxxx> > > > Subject: [lkp@xxxxxxxxx: [linux-next:master 13449/13717] > > > drivers/vdpa/mlx5/net/mlx5_vnet.c:2896:3: error: implicit declaration of > > > function 'mlx5_msix_free' is invalid in C99] > > > > > > CC Dragos. > > > Does one of you want to post a MAINTAINERS patch btw? > > > > > > > > > ----- Forwarded message from kernel test robot <lkp@xxxxxxxxx> ----- > > > > > > From: kernel test robot <lkp@xxxxxxxxx> > > > Date: Sun, 23 Apr 2023 07:29:38 +0800 > > > To: Eli Cohen <elic@xxxxxxxxxx> > > > Cc: llvm@xxxxxxxxxxxxxxx, oe-kbuild-all@xxxxxxxxxxxxxxx, Linux Memory > > > Management List <linux-mm@xxxxxxxxx>, "Michael S. Tsirkin" > > > <mst@xxxxxxxxxx>, Saeed Mahameed <saeedm@xxxxxxxxxx> > > > Subject: [linux-next:master 13449/13717] > > > drivers/vdpa/mlx5/net/mlx5_vnet.c:2896:3: error: implicit declaration of > > > function > > > 'mlx5_msix_free' is invalid in C99 > > > Message-ID: <202304230755.9jjF6ZJr-lkp@xxxxxxxxx> > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > master > > > head: d3e1ee0e67e7603d36f4fa2fec6b881c01aabe89 > > > commit: b9ca712f33f59e977592cb639c2e00a02f45a146 [13449/13717] > > > vdpa/mlx5: Support interrupt bypassing > > > config: x86_64-allmodconfig (https://download.01.org/0day- > > > ci/archive/20230423/202304230755.9jjF6ZJr-lkp@xxxxxxxxx/config) > > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project > > > f28c006a5895fc0e329fe15fead81e37457cb1d1) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp- > > > tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux- > > > next.git/commit/?id=b9ca712f33f59e977592cb639c2e00a02f45a146 > > > git remote add linux-next > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > git fetch --no-tags linux-next master > > > git checkout b9ca712f33f59e977592cb639c2e00a02f45a146 > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang > make.cross > > > W=1 O=build_dir ARCH=x86_64 olddefconfig > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang > make.cross > > > W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/xen/ > > > drivers/power/supply/ drivers/vdpa/mlx5/ > > > > > > If you fix the issue, kindly add following tag where applicable > > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > | Link: https://lore.kernel.org/oe-kbuild-all/202304230755.9jjF6ZJr- > > > lkp@xxxxxxxxx/ > > > > > > Note: the linux-next/master HEAD > > > d3e1ee0e67e7603d36f4fa2fec6b881c01aabe89 builds fine. > > > It may have been fixed somewhere. > > > > > > All errors (new ones prefixed by >>): > > > > > > >> drivers/vdpa/mlx5/net/mlx5_vnet.c:2896:3: error: implicit declaration > of > > > function 'mlx5_msix_free' is invalid in C99 [-Werror,-Wimplicit-function- > > > declaration] > > > mlx5_msix_free(ndev->mvdev.mdev, ent->map); > > > ^ > > > drivers/vdpa/mlx5/net/mlx5_vnet.c:2896:3: note: did you mean > > > 'mlx5_db_free'? > > > include/linux/mlx5/driver.h:1083:6: note: 'mlx5_db_free' declared here > > > void mlx5_db_free(struct mlx5_core_dev *dev, struct mlx5_db *db); > > > ^ > > > >> drivers/vdpa/mlx5/net/mlx5_vnet.c:3259:14: error: implicit declaration > of > > > function 'mlx5_msix_alloc' is invalid in C99 [-Werror,-Wimplicit-function- > > > declaration] > > > ent->map = mlx5_msix_alloc(ndev->mvdev.mdev, int_handler, > > > NULL, ent->name); > > > ^ > > > drivers/vdpa/mlx5/net/mlx5_vnet.c:3259:14: note: did you mean > > > 'mlx5_db_alloc'? > > > include/linux/mlx5/driver.h:1078:19: note: 'mlx5_db_alloc' declared > here > > > static inline int mlx5_db_alloc(struct mlx5_core_dev *dev, struct > mlx5_db > > > *db) > > > ^ > > > >> drivers/vdpa/mlx5/net/mlx5_vnet.c:3259:12: error: assigning to 'struct > > > msi_map' from incompatible type 'int' > > > ent->map = mlx5_msix_alloc(ndev->mvdev.mdev, int_handler, > > > NULL, ent->name); > > > ^ > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > 3 errors generated. > > > > > > > > > vim +/mlx5_msix_free +2896 drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > 2885 > > > 2886 static void free_irqs(struct mlx5_vdpa_net *ndev) > > > 2887 { > > > 2888 struct mlx5_vdpa_irq_pool_entry *ent; > > > 2889 int i; > > > 2890 > > > 2891 if (!msix_mode_supported(&ndev->mvdev)) > > > 2892 return; > > > 2893 > > > 2894 for (i = ndev->irqp.num_ent - 1; i >= 0; i--) { > > > 2895 ent = ndev->irqp.entries + i; > > > > 2896 mlx5_msix_free(ndev->mvdev.mdev, ent- > >map); > > > 2897 } > > > 2898 kfree(ndev->irqp.entries); > > > 2899 } > > > 2900 > > > > > > -- > > > 0-DAY CI Kernel Test Service > > > https://github.com/intel/lkp-tests > > > > > > ----- End forwarded message ----- > >
Attachment:
0001-net-mlx5_core-Modify-mlx5_msix_alloc-free-to-not-req.patch
Description: 0001-net-mlx5_core-Modify-mlx5_msix_alloc-free-to-not-req.patch
Attachment:
0002-vdpa-mlx5-Support-interrupt-bypassing.patch
Description: 0002-vdpa-mlx5-Support-interrupt-bypassing.patch
