(2012/04/17 7:21), Tejun Heo wrote: > On Thu, Apr 12, 2012 at 08:21:20PM +0900, KAMEZAWA Hiroyuki wrote: >> >> When memcg->use_hierarchy==true, the parent res_counter includes >> the usage in child's usage. So, it's not necessary to call try_charge() >> in the parent. >> >> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> >> --- >> mm/memcontrol.c | 39 ++++++++++++++++++++++++++++++++------- >> 1 files changed, 32 insertions(+), 7 deletions(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index fa01106..3215880 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -2409,6 +2409,20 @@ static void __mem_cgroup_cancel_charge(struct mem_cgroup *memcg, >> res_counter_uncharge(&memcg->memsw, bytes); >> } >> } > > New line missing here. > >> +/* >> + * Moving usage between a child to its parent if use_hierarchy==true. >> + */ > > Prolly "from a child to its parent"? > Sure. will fix. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>