(2012/04/17 7:19), Tejun Heo wrote:
> On Thu, Apr 12, 2012 at 08:20:06PM +0900, KAMEZAWA Hiroyuki wrote:
>>
>> This function is used for moving accounting information to its
>> parent in the hierarchy of res_counter.
>>
>> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
>> ---
>> include/linux/res_counter.h | 3 +++
>> kernel/res_counter.c | 13 +++++++++++++
>> 2 files changed, 16 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h
>> index da81af0..8919d3c 100644
>> --- a/include/linux/res_counter.h
>> +++ b/include/linux/res_counter.h
>> @@ -135,6 +135,9 @@ int __must_check res_counter_charge_nofail(struct res_counter *counter,
>> void res_counter_uncharge_locked(struct res_counter *counter, unsigned long val);
>> void res_counter_uncharge(struct res_counter *counter, unsigned long val);
>>
>> +/* move resource to parent counter...i.e. just forget accounting in a child */
>
> Can we drop this comment and
>
>> +void res_counter_move_parent(struct res_counter *counter, unsigned long val);
>>
>> +/*
>> + * In hierarchical accounting, child's usage is accounted into ancestors.
>> + * To move local usage to its parent, just forget current level usage.
>> + */
>
> make this one proper docbook function comment?
>
Sure. (I'll use Frederic's one.)
Thanks,
-Kame
>> +void res_counter_move_parent(struct res_counter *counter, unsigned long val)
>> +{
>> + unsigned long flags;
>> +
>> + BUG_ON(!counter->parent);
>
> And let's please do "if (WARN_ON(!counter->parent)) return;" instead.
>
> Thanks.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>