On Mon, Feb 13, 2023 at 11:15:37AM +0000, David Howells wrote: > I'm not sure I want ki_flags setting from f_iocb_flags I should've said. I'm > not sure how the IOCB_* flags that I import from there will affect the > operation of the synchronous read splice. The same way as they did in the old ITER_PIPE based generic_file_splice_read that uses init_sync_kiocb? And if there's any questions about them we need to do a deep audit. > IOCB_NOWAIT, for example, or, for I'd expect a set IOCB_NOWAIT to make the function return -EAGAIN when it has to block. > that matter, IOCB_APPEND. IOCB_APPEND has no effect on reads of any kind.