Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
From: David Howells <dhowells@xxxxxxxxxx>
Date: Mon, 13 Feb 2023 11:15:37 +0000
Cc: dhowells@xxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>
In-reply-to: <Y+oOa3bbJZallKtl@infradead.org>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <Y+oOa3bbJZallKtl@infradead.org> <Y+n0n2UE8BQa/OwW@infradead.org> <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-4-dhowells@redhat.com> <1753989.1676283061@warthog.procyon.org.uk>

Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> > > Also why doesn't this use init_sync_kiocb?
> > 
> > I'm not sure I want ki_flags.
> 
> Why?

I'm not sure I want ki_flags setting from f_iocb_flags I should've said.  I'm
not sure how the IOCB_* flags that I import from there will affect the
operation of the synchronous read splice.  IOCB_NOWAIT, for example, or, for
that matter, IOCB_APPEND.

David

Follow-Ups:
- Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
  - From: Christoph Hellwig

References:
- Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
  - From: Christoph Hellwig
- Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
  - From: Christoph Hellwig
- [PATCH v13 00/12] iov_iter: Improve page extraction (pin or just list)
  - From: David Howells
- [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
  - From: David Howells
- Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
  - From: David Howells

Prev by Date: Re: [PATCH v2 13/18] lib/stackdepot: annotate depot_init_pool and depot_alloc_stack
Next by Date: Re: [PATCH v2 14/18] lib/stackdepot: rename next_pool_inited to next_pool_required
Previous by thread: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
Next by thread: Re: [PATCH v13 03/12] splice: Do splice read from a buffered file without using ITER_PIPE
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]