On Tue, Jan 31, 2023 at 12:34 PM Alexander Potapenko <glider@xxxxxxxxxx> wrote: > > On Mon, Jan 30, 2023 at 9:50 PM <andrey.konovalov@xxxxxxxxx> wrote: > > > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > > > Give more meaningful names to hash table-related constants and variables: > > > > 1. Rename STACK_HASH_SCALE to STACK_TABLE_SCALE to point out that it is > > related to scaling the hash table. > > It's only used twice, and in short lines, maybe make it > STACK_HASH_TABLE_SCALE to point that out? :) Sure, sounds good :) > > 2. Rename STACK_HASH_ORDER_MIN/MAX to STACK_BUCKET_NUMBER_ORDER_MIN/MAX > > to point out that it is related to the number of hash table buckets. > > How about DEPOT_BUCKET_... or STACKDEPOT_BUCKET_...? > (just bikeshedding, I don't have any strong preference). This is what I had initially actually but then decided to keep the prefix as STACK_ to match the stack_slabs and stack_table variables. However, I can also rename those variables to depot_slabs and depot_table. Do you think it makes sense?
