On Tue, Jan 31, 2023 at 11:43 AM Alexander Potapenko <glider@xxxxxxxxxx> wrote: > > On Mon, Jan 30, 2023 at 9:50 PM <andrey.konovalov@xxxxxxxxx> wrote: > > > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > > > Group stack depot global variables by their purpose: > > > > 1. Hash table-related variables, > > 2. Slab-related variables, > > > > and add comments. > > > > Also clean up comments for hash table-related constants. > > > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx> > > ... > > +/* Lock that protects the variables above. */ > > +static DEFINE_RAW_SPINLOCK(depot_lock); > > +/* Whether the next slab is initialized. */ > > +static int next_slab_inited; > Might be worth clarifying what happens if there's no next slab (see my > comment to patch 01). Will do in v2. Thanks!