Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > My point was to change that to take a 'bool unpin' because FOLL_PIN is > not to be used outside gup.c I need a 3-state wrapper. But if I can't do it in gup.c, then I'll have to do it elsewhere. As Christoph says, most of the places will only be pinned or not-pinned. The whole point was to avoid generating new constants when existing constants would do. David.