On Tue, Jan 24, 2023 at 01:46:23PM +0000, David Howells wrote: > Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > > > Yeah, I already wrote a similar patch, using the 1<< notation, > > splitting the internal/external, and rebasing on the move to > > mm_types.. I can certainly drop that patch if we'd rather do this. > > Note that I've already given Andrew a patch to move FOLL_* to mm_types.h. > > I'm happy to go with your patch on top of that if you can just renumber > FOLL_PIN to 0 and FOLL_GET to 1. I moved FOLL_PIN to internal.h because it is not supposed to be used outside mm/* I would prefer to keep it that way. Jason
