On Fri, 2023-01-06 at 09:09 -0800, Dave Hansen wrote:
> On 12/8/22 22:52, Kai Huang wrote:
> > +++ b/arch/x86/virt/vmx/tdx/tdx.h
> > @@ -0,0 +1,15 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _X86_VIRT_TDX_H
> > +#define _X86_VIRT_TDX_H
> > +
> > +/*
> > + * This file contains both macros and data structures defined by the TDX
> > + * architecture and Linux defined software data structures and functions.
> > + * The two should not be mixed together for better readability. The
> > + * architectural definitions come first.
> > + */
> > +
> > +/* MSR to report KeyID partitioning between MKTME and TDX */
> > +#define MSR_IA32_MKTME_KEYID_PARTITIONING 0x00000087
>
> The *VAST* majority of MSR definitions are in msr-index.h.
>
> Why is this one different from the norm?
I had memory that only when one MSR is shared by multiple source files the
definition of that MSR should go into msr-index.h, but this has changed since
commit 97fa21f65c3e ("x86/resctrl: Move MSR defines into msr-index.h").
I'll move it to msr-index.h
