Re: [PATCH bpf-next v5 3/6] selftests/vm: extend test_vmalloc to test execmem_* APIs

[Song Liu <song@xxxxxxxxxx>]

On Tue, Nov 29, 2022 at 12:35 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC
> > +EXPORT_SYMBOL_GPL(execmem_alloc);
> > +#endif
>
> > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC
> > +EXPORT_SYMBOL_GPL(execmem_fill);
> > +#endif
>
> > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC
> > +EXPORT_SYMBOL_GPL(execmem_free);
> > +#endif
>
> Still NAK.  These symbols never have any business being exported
> ever.  Just force the test to be built-in if you want to test this
> functionality.

OK. I knew this was really ugly. I just want to know your thoughts on it.

I guess we can just drop 3/6 of the set, and everything else would just work.

Thanks,
Song