Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Mon, 14 Nov 2022 17:47:21 +0000
Cc: kernel test robot <lkp@xxxxxxxxx>, Jakob Koschel <jakobkoschel@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, oe-kbuild-all@xxxxxxxxxxxxxxx, Kevin Cernekee <cernekee@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linux Memory Management List <linux-mm@xxxxxxxxx>
In-reply-to: <Y3JmtNExJulq2CEE@smile.fi.intel.com>
References: <20221114112842.38565-1-andriy.shevchenko@linux.intel.com> <202211142350.i0ngTfIl-lkp@intel.com> <Y3JmtNExJulq2CEE@smile.fi.intel.com>

On Mon, Nov 14, 2022 at 06:03:00PM +0200, Andy Shevchenko wrote:
> Oh, nice! I will fix this for v2.

list_count() is an antipattern.  I don't have any of the patches in
my inbox, so maybe there's a great reason for doing this, but my
immediate response is: NAK.

Follow-Ups:
- Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes
  - From: Andy Shevchenko

References:
- Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes
  - From: kernel test robot
- Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH] filemap: skip range writeback if end offset precedes start
Next by Date: Re: [External] Re: [PATCH v2] mm: add new syscall pidfd_set_mempolicy().
Previous by thread: Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes
Next by thread: Re: [PATCH v1 1/4] list: Introduce list_count() to count existing nodes
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]