On Wed 2022-11-09 15:14:05, Hyeonggon Yoo wrote: > On Sun, Nov 06, 2022 at 10:04:25AM -0800, Joe Perches wrote: > > On Sun, 2022-11-06 at 23:03 +0900, Hyeonggon Yoo wrote: > > > dump_page() uses %pGp format to print 'flags' field of struct page. > > > As some page flags (e.g. PG_buddy, see page-flags.h for more details) > > > are set in page_type field, introduce %pGt format which provides > > > human readable output of page_type. And use it in dump_page(). > > [] > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > [] > > > @@ -2056,6 +2056,28 @@ char *format_page_flags(char *buf, char *end, unsigned long flags) > > > return buf; > > > } > > > > > > +static > > Thanks for looking at this. > > > > > noinline_for_stack ? Honestly, I do not like much adding this without numbers. It has been added to some functions in vsprintf.c long time ago because it reduced the stack usage. But I think that it is a compiler and an architecture specific. And it is not clear if it would really help in this particular case. Feel free to omit it. Best Regards, Petr
