On Wed 02-11-22 08:39:25, Michal Hocko wrote: > On Tue 01-11-22 12:13:35, Zach O'Keefe wrote: > [...] > > This is slightly tangential - but I don't want to send a new mail > > about it -- but I wonder if we should be doing __GFP_THISNODE + > > explicit node vs having hpage_collapse_find_target_node() set a > > nodemask. We could then provide fallback nodes for ties, or if some > > node contained > some threshold number of pages. > > I would simply go with something like this (not even compile tested): Btw. while at it. It is really ugly to allocate 4kB stack space for node mask for !NUMA configurations! If you are touching that area then this shouldn't be hard to fix. -- Michal Hocko SUSE Labs