Re: [PATCH v5 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter counter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  /*
@@ -2414,6 +2417,10 @@ int unpoison_memory(unsigned long pfn)
  unlock_mutex:
  	mutex_unlock(&mf_mutex);
  	if (!ret || freeit) {
+		/*
+		 * TODO: per-memory_block counter might break when the page
+		 * size to be unpoisoned is larger than a memory_block.
+		 */

Hmm, but that happens easily e.g., with 1 GiB hugetlb page and 128 MiB memory section/block size. What would be the right thing to do here? The TODO should rather spell that out instead of just stating the problem.

--
Thanks,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux