Hi Andrea, On Wed, Mar 7, 2012 at 8:26 AM, Andrea Arcangeli <aarcange@xxxxxxxxxx> wrote: > On Wed, Mar 07, 2012 at 01:11:48AM +0100, Andrea Arcangeli wrote: >> (the function was invoked only on compound pages in the first place). > > BTW, most certainly I did at some point this change: > > - if (page_trans_compound_anon_split(page)) > + if (PageTransCompound(page) && page_trans_compound_anon_split(page)) > > Before doing this change, the "cleaned up" version would have been > broken. > I think this patch may still break the origin meaning. In case PageTransCompound(page) but !PageAnon(head) after this cleanup, page_trans_compound_anon_split(page) will return 1 instead of 0 which will cause following PageAnon check to a compounded page. So please just ignore this cleanup. Sorry for my noise. Hugh, Thank you for your review also. -- Regards, --Bob -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href