On Wed, Mar 07, 2012 at 01:11:48AM +0100, Andrea Arcangeli wrote: > (the function was invoked only on compound pages in the first place). BTW, most certainly I did at some point this change: - if (page_trans_compound_anon_split(page)) + if (PageTransCompound(page) && page_trans_compound_anon_split(page)) Before doing this change, the "cleaned up" version would have been broken. The original idea was to return 1 only in real error condition when a THP splitting failure was encountered. So it had to be neutral and not error out if split_huge_page wasn't needed. In short the cleaned up version of page_trans_compound_anon_split is a bit less generic but it being a static and only used here I don't mind too much. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>