On 9/6/2022 8:53 AM, Marek Vasut wrote:
On 9/5/22 04:54, Chen, Rong A wrote:
On 9/3/2022 10:31 PM, Marek Vasut wrote:
On 9/3/22 01:21, kernel test robot wrote:
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8
commit: 822a6200734c94ccbfc9ae7acc5da5505b991515 [2262/4736] extcon:
usbc-tusb320: Add USB TYPE-C support
config: x86_64-randconfig-a003
(https://download.01.org/0day-ci/archive/20220903/202209030755.eB4SkwGE-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project
f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=822a6200734c94ccbfc9ae7acc5da5505b991515
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 822a6200734c94ccbfc9ae7acc5da5505b991515
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross
W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/extcon/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/extcon/extcon-usbc-tusb320.c:19: warning: expecting
prototype for drivers/extcon/extcon-tusb320.c(). Prototype was for
TUSB320_REG8() instead
vim +19 drivers/extcon/extcon-usbc-tusb320.c
18
> 19 #define TUSB320_REG8 0x8
20 #define TUSB320_REG8_CURRENT_MODE_ADVERTISE GENMASK(7, 6)
21 #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_USB 0x0
22 #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_15A 0x1
23 #define TUSB320_REG8_CURRENT_MODE_ADVERTISE_30A 0x2
24 #define TUSB320_REG8_CURRENT_MODE_DETECT GENMASK(5, 4)
25 #define TUSB320_REG8_CURRENT_MODE_DETECT_DEF 0x0
26 #define TUSB320_REG8_CURRENT_MODE_DETECT_MED 0x1
27 #define TUSB320_REG8_CURRENT_MODE_DETECT_ACC 0x2
28 #define TUSB320_REG8_CURRENT_MODE_DETECT_HI 0x3
29 #define TUSB320_REG8_ACCESSORY_CONNECTED GENMASK(3, 2)
30 #define TUSB320_REG8_ACCESSORY_CONNECTED_NONE 0x0
31 #define TUSB320_REG8_ACCESSORY_CONNECTED_AUDIO 0x4
32 #define TUSB320_REG8_ACCESSORY_CONNECTED_ACC 0x5
33 #define TUSB320_REG8_ACCESSORY_CONNECTED_DEBUG 0x6
34 #define TUSB320_REG8_ACTIVE_CABLE_DETECTION BIT(0)
35
I still believe this is a false positive, is it not ?
Hi Marek,
Thanks for your reply, the issue is not introduced by this commit, it
should be related to '/**' in the head of this file:
diff --git a/drivers/extcon/extcon-usbc-tusb320.c
b/drivers/extcon/extcon-usbc-tusb320.c
index edb8c3f997c9..41041ff0fadb 100644
--- a/drivers/extcon/extcon-usbc-tusb320.c
+++ b/drivers/extcon/extcon-usbc-tusb320.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* drivers/extcon/extcon-tusb320.c - TUSB320 extcon driver
*
* Copyright (C) 2020 National Instruments Corporation
Uh, OK, I wouldn't have thought of that based on the output above.
The change above is obviously correct, can you submit a patch ?
Hi Marek,
Thanks for the review, I have submitted it:
https://lore.kernel.org/lkml/20220906040430.35896-1-rong.a.chen@xxxxxxxxx/T/#u
Best Regards,
Rong Chen
Thanks !
_______________________________________________
kbuild-all mailing list -- kbuild-all@xxxxxxxxxxxx
To unsubscribe send an email to kbuild-all-leave@xxxxxxxxxxxx
