Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Oliver Sang <oliver.sang@xxxxxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
From: John Garry <john.garry@xxxxxxxxxx>
Date: Fri, 19 Aug 2022 08:54:42 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "Linux Memory Management List" <linux-mm@xxxxxxxxx>, <linux-ide@xxxxxxxxxxxxxxx>, <lkp@xxxxxxxxxxxx>, <lkp@xxxxxxxxx>, <ying.huang@xxxxxxxxx>, <feng.tang@xxxxxxxxx>, <zhengjun.xing@xxxxxxxxxxxxxxx>, <fengwei.yin@xxxxxxxxx>
In-reply-to: <Yv8sg3J8PLD56osY@xsang-OptiPlex-9020>
References: <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com> <f1c3d717-339d-ba2b-9775-fc0e00f57ae3@huawei.com> <Yvs/w93KUkgD9f7/@xsang-OptiPlex-9020> <aabf7ed8-8d4d-dc68-1b8b-c91653701def@huawei.com> <43eaa104-5b09-072c-56aa-6289569b0015@opensource.wdc.com> <28d6e48b-f52f-9467-8260-262504a1a1ff@huawei.com> <YvzyZJUblfqN6Xj3@xsang-OptiPlex-9020> <743867a6-b266-58e4-a8a6-542757916f0a@huawei.com> <Yv2euLFLjl8bEaeI@xsang-OptiPlex-9020> <d1b1d434-059d-4d76-5fc6-092ab9ba6e16@huawei.com> <Yv8sg3J8PLD56osY@xsang-OptiPlex-9020>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1

On 19/08/2022 07:24, Oliver Sang wrote:

As you probably saw, I sent "[RFT PATCH] ata: libata: Set __ATA_BASE_SHT
max_sectors" for testing on top of v6.0-rc1, and I hope that then we can get

Based on result below, I wonder if SAS HBAs (which use libata) shouldnot use default SCSI max_sectors also. Any libsas HBA driver does today,IIRC.

same performance as v5.19

yeah, our test confirmed your expectation:

stress-ng.copy-file.ops_per_sec
v5.19                 - 26.85
v6.0-rc1              - 23.03
v6.0-rc1 + your patch - 26.94


great, thanks

Thanks,
John

References:
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: John Garry
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: John Garry
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: Oliver Sang
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: John Garry
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: Damien Le Moal
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: John Garry
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: Oliver Sang
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: John Garry
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: Oliver Sang
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: John Garry
- Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
  - From: Oliver Sang

Prev by Date: Re: [PATCH] mm: hugetlb_vmemmap: simplify reset_struct_pages()
Next by Date: [PATCH RESEND] mm: hugetlb: simplify per-node sysfs creation and removal
Previous by thread: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
Next by thread: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]