On Mon, 20 Feb 2012, Jan Kara wrote: > On Thu 16-02-12 11:13:53, Sage Weil wrote: > > On Thu, 16 Feb 2012, Alex Elder wrote: > > > On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: > > > > CC: Sage Weil <sage@xxxxxxxxxxxx> > > > > CC: ceph-devel@xxxxxxxxxxxxxxx > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > > > > > > > > This will update the timestamp even if a write > > > fault fails, which is different from before. > > > > > > Hard to avoid though. > > > > > > Looks good to me. > > > > Yeah. Let's put something in the tracker to take a look later (I think we > > can do better), but this is okay for now. > > > > Signed-off-by: Sage Weil <sage@xxxxxxxxxxxx> > Thanks! Just an administrative note - the tag above should rather be > Acked-by or Reviewed-by. You'd use Signed-off-by only if you took the patch > and merged it via your tree... So can I add Acked-by? Oh, right. Acked-by! sage > > Honza > > > > Signed-off-by: Alex Elder <elder@xxxxxxxxxxxxx> > > > > > > > fs/ceph/addr.c | 3 +++ > > > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > > > > index 173b1d2..12b139f 100644 > > > > --- a/fs/ceph/addr.c > > > > +++ b/fs/ceph/addr.c > > > > @@ -1181,6 +1181,9 @@ static int ceph_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > > > > loff_t size, len; > > > > int ret; > > > > > > > > + /* Update time before taking page lock */ > > > > + file_update_time(vma->vm_file); > > > > + > > > > size = i_size_read(inode); > > > > if (off + PAGE_CACHE_SIZE <= size) > > > > len = PAGE_CACHE_SIZE; > > > > > > > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > > > -- > Jan Kara <jack@xxxxxxx> > SUSE Labs, CR > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>