On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: > CC: Sage Weil <sage@xxxxxxxxxxxx> > CC: ceph-devel@xxxxxxxxxxxxxxx > Signed-off-by: Jan Kara <jack@xxxxxxx> This will update the timestamp even if a write fault fails, which is different from before. Hard to avoid though. Looks good to me. Signed-off-by: Alex Elder <elder@xxxxxxxxxxxxx> > fs/ceph/addr.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 173b1d2..12b139f 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -1181,6 +1181,9 @@ static int ceph_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > loff_t size, len; > int ret; > > + /* Update time before taking page lock */ > + file_update_time(vma->vm_file); > + > size = i_size_read(inode); > if (off + PAGE_CACHE_SIZE <= size) > len = PAGE_CACHE_SIZE; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>