On Tue, Jun 14, 2022 at 09:40:08AM -0700, Yury Norov wrote:
> On Mon, Jun 13, 2022 at 8:45 PM <wang.yi59@xxxxxxxxxx> wrote:
> > > On Mon, Jun 13, 2022 at 4:31 AM Yi Wang <wang.yi59@xxxxxxxxxx> wrote:
...
> > > Anyways, as per name, bitmap_remap() is intended to change bit
> > > positions, and it doesn't look wrong if it does so.
Haven't read the discussion in full, but saw the function here and my 2 cents
are the following:
1) if we don't have tests for bitmap_remap() / bitmap_bitremap(), we should;
2) these functions are used at least in one GPIO driver, so it would be nice
to not touch them if they are not broken (see 1 above).
--
With Best Regards,
Andy Shevchenko
