> > On Tue, Jun 07, 2022 at 11:34:46AM +0200, Uladzislau Rezki (Sony) wrote: > > It implies that __alloc_vmap_area() allocates only from the > > global vmap space, therefore a list-head and rb-tree, which > > represent a free vmap space, are not passed as parameters to > > this function and are accessed directly from this function. > > Yes, which totally makes sense. > > > Extend the __alloc_vmap_area() and other dependent functions > > to have a possibility to allocate from different trees making > > an interface common and not specific. > > Which seems completely pointless. Why add argument that are always > passed the same values? > I wrote about it in the cover latter. It is a preparation work for making vmalloc per-cpu. In that case free/busy data are located on different rb_roots that is why those functions have to be adopted to work with any tree. -- Uladzislau Rezki