On 5/22/22 12:24 AM, Christoph Hellwig wrote: >> +int file_modified_async(struct file *file, int flags) > > file_modified_flags? Or even bette kiocb_modified and pass the > kiocb as that makes is very clear which flags we use by making that > implicit. > - Renamed file_modified_async() to file_modified_flags() - Made file_modified_flags() an internal function - Add kiocb_modified function. >> +EXPORT_SYMBOL(file_modified_async); > > EXPORT_SYMBOL_GPL, please. Done. > >> - return file_modified(file); >> + return file_modified_async(file, iocb->ki_flags); > > And this should go into the XFS enablemnt patch. > >> extern int file_modified(struct file *file); >> +extern int file_modified_async(struct file *file, int flags); > > No need for the extern here, or any function declarations for that > matter. - Removed extern keyword in file_modified_async definition
