Re: [RFC PATCH v4 11/17] fs: Add async write file modification handling.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +int file_modified_async(struct file *file, int flags)

file_modified_flags?  Or even bette kiocb_modified and pass the
kiocb as that makes is very clear which flags we use by making that
implicit.

> +EXPORT_SYMBOL(file_modified_async);

EXPORT_SYMBOL_GPL, please.

> -	return file_modified(file);
> +	return file_modified_async(file, iocb->ki_flags);

And this should go into the XFS enablemnt patch.

>  extern int file_modified(struct file *file);
> +extern int file_modified_async(struct file *file, int flags);

No need for the extern here, or any function declarations for that
matter.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux