On 25.04.22 15:27, Miaohe Lin wrote: > We might fail to isolate huge page due to e.g. the page is under migration > which cleared HPageMigratable. So we should return -EBUSY in this case > rather than always return 1 which could confuse the user. Also we make > the prototype of isolate_huge_page consistent with isolate_lru_page to > improve the readability. > > Fixes: e8db67eb0ded ("mm: migrate: move_pages() supports thp migration") If this is a fix, what's the runtime effect of it? You state "could confuse", which doesn't indicate an actual BUG to me. -- Thanks, David / dhildenb