On 4/22/22 00:10, Pasha Tatashin wrote: > On 4/21/22 11:28, Pasha Tatashin wrote: >> On Thu, Apr 21, 2022 at 4:02 AM Tong Tiangen <tongtiangen@xxxxxxxxxx> wrote: >>> Macro PUD_SIZE/PMD_SIZE is more general in various architectures. Using >>> PUD_SIZE/PMD_SIZE instead of PUD_PAGE_SIZE/PMD_PAGE_SIZE can better >>> support page table check in architectures other than x86 and it is no >>> functional impact on x86. >>> >>> Suggested-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> >>> Signed-off-by: Tong Tiangen <tongtiangen@xxxxxxxxxx> >> Acked-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx> > > To avoid similar problems in the future, please also include the following patch after the current series: > > ----------------8<-------------[ cut here ]------------------ >>From cccef7ba2433f8e97d1948f85e3bfb2ef5d32a0a Mon Sep 17 00:00:00 2001 > From: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx> > Date: Thu, 21 Apr 2022 18:04:43 +0000 > Subject: [PATCH] x86: removed P*D_PAGE_MASK and P*D_PAGE_SIZE > > Other architectures and the common mm/ use P*D_MASK, and P*D_SIZE. > Remove the duplicated P*D_PAGE_MASK and P*D_PAGE_SIZE which are only > used in x86/*. > > Signed-off-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx> Absolutely, helps in minimizing arch specific stuff wrt to page table mapping.
