On 2022/4/11 11:17, Matthew Wilcox wrote:
> On Mon, Apr 11, 2022 at 09:53:15AM +0800, Miaohe Lin wrote:
>> On 2022/4/9 21:44, Matthew Wilcox wrote:
>>> On Sat, Apr 09, 2022 at 05:34:54PM +0800, Miaohe Lin wrote:
>>>> + nr_reclaimed = shrink_page_list(page_list, pgdat, &sc, &dummy_stat, false);
>>>> + while (!list_empty(page_list)) {
>>>> + folio = lru_to_folio(page_list);
>>>> + list_del(&folio->lru);
>>>> + putback_lru_page(&folio->page);
>>>
>>> folio_putback_lru()
>>
>> I thought folio_putback_lru is deliberately not to use because there is no caller of folio_putback_lru now.
>> But it seems I was wrong. Will do it in next version.
>
> Looks like all of the uses of it that I mooted during the last merge
> window ended up going away.
>
> https://lore.kernel.org/all/20220204195852.1751729-47-willy@xxxxxxxxxxxxx/
> was obsoleted by commit b109b87050df
>
> https://lore.kernel.org/all/20220204195852.1751729-48-willy@xxxxxxxxxxxxx/
> and
> https://lore.kernel.org/all/20220204195852.1751729-50-willy@xxxxxxxxxxxxx/
> were also obsoleted by Hugh's mlock changes
>
> I also sent
> https://lore.kernel.org/all/YjJJIrENYb1qFHzl@xxxxxxxxxxxxxxxxxxxx/
>
> but never quite got it up to submittable quality.
I see. This is really a pity. Many thanks for clarifying. :)
>
> .
>
