Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Subject: Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 29 Mar 2022 07:00:29 -0700
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20220329132619.18689-4-linmiaohe@huawei.com>
References: <20220329132619.18689-1-linmiaohe@huawei.com> <20220329132619.18689-4-linmiaohe@huawei.com>

> +static inline unsigned int reclaim_page_list(struct list_head *page_list, struct pglist_data *pgdat)

This is completely unreadable with the crazy long lines.

Also why would you force inline this?

Follow-Ups:
- Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()
  - From: Miaohe Lin

References:
- [PATCH 0/8] A few cleanup and fixup patches for migration
  - From: Miaohe Lin
- [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()
  - From: Miaohe Lin

Prev by Date: Re: [PATCH v2 01/15] mm/rmap: fix missing swap_free() in try_to_unmap() after arch_unmap_one() failed
Next by Date: Re: [PATCH 4/8] mm/vmscan: save a bit of stack space in shrink_lruvec
Previous by thread: Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()
Next by thread: Re: [PATCH 3/8] mm/vmscan: introduce helper function reclaim_page_list()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux