On Tue, Mar 15, 2022 at 4:52 PM Michal Hocko <mhocko@xxxxxxxx> wrote: > > On Mon 14-03-22 22:51:50, Wei Yang wrote: > > On Mon, Mar 14, 2022 at 10:54:03AM +0100, Michal Hocko wrote: > > >On Sat 12-03-22 07:16:22, Wei Yang wrote: > > >> There is no tree operation if mz is not on-tree. > > > > > >This doesn't explain problem you are trying to solve nor does it make > > >much sense to me TBH. > > > > > > > This just tries to make the code looks consistent. > > I guess this is rather subjective. One could argue that the check is > more descriptive because it obviously removes the node from the tree > when it is on the tree. Hmm... maybe yes. If someone else prefer the original one, I am ok with it. > -- > Michal Hocko > SUSE Labs