On Mon 14-03-22 22:51:50, Wei Yang wrote: > On Mon, Mar 14, 2022 at 10:54:03AM +0100, Michal Hocko wrote: > >On Sat 12-03-22 07:16:22, Wei Yang wrote: > >> There is no tree operation if mz is not on-tree. > > > >This doesn't explain problem you are trying to solve nor does it make > >much sense to me TBH. > > > > This just tries to make the code looks consistent. I guess this is rather subjective. One could argue that the check is more descriptive because it obviously removes the node from the tree when it is on the tree. -- Michal Hocko SUSE Labs