On Thu, Mar 3, 2022 at 4:21 PM Ivan Babrou <ivan@xxxxxxxxxxxxxx> wrote: > > On Wed, Mar 2, 2022 at 6:35 PM Shakeel Butt <shakeelb@xxxxxxxxxx> wrote: > > > > On Wed, Mar 02, 2022 at 02:33:41PM -0800, Ivan Babrou wrote: > > > On Tue, Mar 1, 2022 at 7:40 PM Ivan Babrou <ivan@xxxxxxxxxxxxxx> wrote: > > [...] > > > > Please try the following patch: > > * Linux 5.10.101: > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 5496 |****************************************| > 512 -> 1023 : 3161 |*********************** | > 1024 -> 2047 : 1059 |******* | > 2048 -> 4095 : 3149 |********************** | > 4096 -> 8191 : 2074 |*************** | > 8192 -> 16383 : 90 | | > 16384 -> 32767 : 43 | | > 32768 -> 65535 : 44 | | > 65536 -> 131071 : 12 | | > 131072 -> 262143 : 3 | | > 262144 -> 524287 : 1 | | > > avg = 2144 nsecs, total: 32453571 nsecs, count: 15132 > > * Linux 5.15.25: > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 132411 |****************************************| > 512 -> 1023 : 45547 |************* | > 1024 -> 2047 : 5869 |* | > 2048 -> 4095 : 10553 |*** | > 4096 -> 8191 : 5297 |* | > 8192 -> 16383 : 455 | | > 16384 -> 32767 : 214 | | > 32768 -> 65535 : 175 | | > 65536 -> 131071 : 50 | | > 131072 -> 262143 : 6 | | > 262144 -> 524287 : 2 | | > 524288 -> 1048575 : 80 | | > 1048576 -> 2097151 : 3228 | | > 2097152 -> 4194303 : 13514 |**** | > 4194304 -> 8388607 : 792 | | > 8388608 -> 16777215 : 1 | | > > avg = 221955 nsecs, total: 48429632352 nsecs, count: 218195 > > * Linux 5.15.25 + delayed flush: > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 103067 |****************************************| > 512 -> 1023 : 39054 |*************** | > 1024 -> 2047 : 8953 |*** | > 2048 -> 4095 : 12986 |***** | > 4096 -> 8191 : 10173 |*** | > 8192 -> 16383 : 8090 |*** | > 16384 -> 32767 : 890 | | > 32768 -> 65535 : 540 | | > 65536 -> 131071 : 198 | | > 131072 -> 262143 : 50 | | > 262144 -> 524287 : 7 | | > > avg = 1837 nsecs, total: 338115740 nsecs, count: 184008 > > * Linux 5.15.25 + your latest patch with "if_late": > > $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault > Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. > > nsecs : count distribution > 0 -> 1 : 0 | | > 2 -> 3 : 0 | | > 4 -> 7 : 0 | | > 8 -> 15 : 0 | | > 16 -> 31 : 0 | | > 32 -> 63 : 0 | | > 64 -> 127 : 0 | | > 128 -> 255 : 0 | | > 256 -> 511 : 9241 |****************************************| > 512 -> 1023 : 7041 |****************************** | > 1024 -> 2047 : 1457 |****** | > 2048 -> 4095 : 3401 |************** | > 4096 -> 8191 : 2207 |********* | > 8192 -> 16383 : 130 | | > 16384 -> 32767 : 53 | | > 32768 -> 65535 : 40 | | > 65536 -> 131071 : 16 | | > 131072 -> 262143 : 1 | | > 262144 -> 524287 : 1 | | > > avg = 1663 nsecs, total: 39249164 nsecs, count: 23588 > > The numbers look pretty good. Thanks a lot Ivan. I will send the signed-off patch for 'if_late' and I would like to have your Tested-by on that.
