On Mon, Feb 28, 2022 at 3:34 PM Ivan Babrou <ivan@xxxxxxxxxxxxxx> wrote: > I scheduled some reboots for overnight, one machine in each group: > > 1. Control on 5.15.25 > 2. Your previous patch with delayed flush on top of 5.15.25 > 3. Your current patch with targeted flush on top of 5.15.25 > > Either Daniel or I should have some numbers tomorrow. Numbers for #2 (previous patch): $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 27313 |****************************************| 512 -> 1023 : 11887 |***************** | 1024 -> 2047 : 3718 |***** | 2048 -> 4095 : 7095 |********** | 4096 -> 8191 : 11860 |***************** | 8192 -> 16383 : 4193 |****** | 16384 -> 32767 : 470 | | 32768 -> 65535 : 320 | | 65536 -> 131071 : 107 | | 131072 -> 262143 : 20 | | 262144 -> 524287 : 2 | | avg = 2929 nsecs, total: 196247510 nsecs, count: 66985 Numbers for #3 (the latest patch): $ sudo /usr/share/bcc/tools/funclatency -d 60 workingset_refault Tracing 1 functions for "workingset_refault"... Hit Ctrl-C to end. nsecs : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 6520 |****************************************| 512 -> 1023 : 3502 |********************* | 1024 -> 2047 : 726 |**** | 2048 -> 4095 : 2206 |************* | 4096 -> 8191 : 1078 |****** | 8192 -> 16383 : 70 | | 16384 -> 32767 : 39 | | 32768 -> 65535 : 28 | | 65536 -> 131071 : 8 | | 131072 -> 262143 : 1 | | 262144 -> 524287 : 11 | | 524288 -> 1048575 : 118 | | 1048576 -> 2097151 : 3722 |********************** | 2097152 -> 4194303 : 5854 |*********************************** | 4194304 -> 8388607 : 570 |*** | 8388608 -> 16777215 : 122 | | avg = 1100789 nsecs, total: 27051906434 nsecs, count: 24575 Looks like you were right that targeted flush is not going to be as good.