On Wed, Mar 2, 2022 at 8:32 PM Catalin Marinas <catalin.marinas@xxxxxxx> wrote: > > On Wed, Mar 02, 2022 at 04:46:23PM +0800, Muchun Song wrote: > > When a contiguous HugeTLB page is mapped, set_pte_at() will be called > > CONT_PTES/CONT_PMDS times. Therefore, __sync_icache_dcache() will > > flush cache multiple times if the page is executable (to ensure > > the I-D cache coherency). However, the first flushing cache already > > covers subsequent cache flush operations. So only flusing cache > > for the head page if it is a HugeTLB page to avoid redundant cache > > flushing. In the next patch, it is also depends on this change > > since the tail vmemmap pages of HugeTLB is mapped with read-only > > meanning only head page struct can be modified. > > > > Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> > > Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx> Thanks for your review. > > (for this patch only, I have yet to figure out whether Anshuman's and > Mark's comments have been addressed in patch 2) > Their comments are memory hotplug related, actually, those issues are not real issues as I explained in patch 2. And If you have any questions, feel free to ask, maybe I can help. Thanks Catalin.
