On 2/16/22 20:54, Peter Xu wrote:
On Wed, Feb 16, 2022 at 07:25:14PM -0800, John Hubbard wrote:
On 2/16/22 1:48 AM, Peter Xu wrote:
Clean the code up by merging the device private/exclusive swap entry handling
with the rest, then we merge the pte clear operation too.
Maybe also mention that you reduced the code duplication in the
is_device_private_entry() area, by letting it fall through to the common
pte_clear_not_present_full() at the end of the loop? Since you're listing
the other changes, that one seems worth mentioning.
Isn't that the "we merge the pte clear operation" part? :)
Somehow that part wasn't as clear to me, but...
I can add another sentence to it, if it looks better to you:
---8<---
Clean the code up by merging the device private/exclusive swap entry
handling with the rest, then we merge the pte clear operation too. We do
it by letting the private/exclusive block fall through to the last call to
pte_clear_not_present_full().
---8<---
...no need to change anything here. I just wanted the list to be complete,
and it is.
thanks,
--
John Hubbard
NVIDIA
