On 2/16/22 20:46, Peter Xu wrote:
...
I personally used 78/79 col width for a long time for different projects, but
sure I can adjust my config. I found that the "official guide" points us to
75 instead:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
The body of the explanation, line wrapped at 75 columns, which will be copied
to the permanent changelog to describe this patch.
I'll follow that.
Oh, I'll change to that too, then. Thanks for spotting that.
[...]
+ if (!should_zap_cows(details))
+ continue;
rss[MM_SWAPENTS]--;
- else if (is_migration_entry(entry)) {
Can we put a newline here, and before each "else" block? Because now it
is getting very dense, and the visual separation really helps.
The thing is we don't have a rule to add empty lines here, or do we? Changing
it could make it less like what we have had.
I'm not claiming rules or standards, this is just a special case of trying
to make it a little nicer. No big deal either way, of course.
thanks,
--
John Hubbard
NVIDIA
