On Mon, Jan 31, 2022 at 11:24:48AM +0100, Michal Hocko wrote: >> >> This patch restore the original behavior by using the same criteria to >> >> add a zone in zonelist during memory hotplug. >> > >> >Why? >> > >> >> In case we online a populated zone, but not managed. Then this zone will not >> be in zonelist. Right? > >yeah. We can theoretically end up with a zone without any managed menory >on the zonelists. But my primary question is why do we need this change? Currently I don't see a real case for this. >Does it fix any existing problem? Does it make the code easier to >read/understand? Does it improve performance? Every patch should have a >justification. Your changelog merely lists the history and then states >the new behavior without any explanation of why that is needed or >desired. See? I don't have such reason now. >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me
