Le 24/01/2022 à 13:32, Christoph Hellwig a écrit : > On Mon, Jan 24, 2022 at 09:22:15AM +0000, Christophe Leroy wrote: >> +static inline bool within_range(unsigned long addr, void *base, unsigned int size) > > Please avoid the overly long line. > > .. But given that this function only has a single caller I see no > point in factoring it out anyway. Patch 2 brings a second caller. Having it in patch 1 reduces churn in patch 2. Is it the wrong way to do ? Christophe
