Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
Subject: Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 24 Jan 2022 04:32:12 -0800
Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>, Jessica Yu <jeyu@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linuxppc-dev@xxxxxxxxxxxxxxxx" <linuxppc-dev@xxxxxxxxxxxxxxxx>, "kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx" <kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>
In-reply-to: <e5e58875bd15551d0386552d3f9fa9ee8bc183a2.1643015752.git.christophe.leroy@csgroup.eu>
References: <cover.1643015752.git.christophe.leroy@csgroup.eu> <e5e58875bd15551d0386552d3f9fa9ee8bc183a2.1643015752.git.christophe.leroy@csgroup.eu>

On Mon, Jan 24, 2022 at 09:22:15AM +0000, Christophe Leroy wrote:
> +static inline bool within_range(unsigned long addr, void *base, unsigned int size)

Please avoid the overly long line.

.. But given that this function only has a single caller I see no
point in factoring it out anyway.

Follow-Ups:
- Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init()
  - From: Christophe Leroy
- Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init()
  - From: Christophe Leroy

References:
- [PATCH 0/7] Allocate module text and data separately
  - From: Christophe Leroy
- [PATCH 1/7] modules: Refactor within_module_core() and within_module_init()
  - From: Christophe Leroy

Prev by Date: Re: [PATCH 7/7] powerpc: Select ARCH_WANTS_MODULES_DATA_IN_VMALLOC on book3s/32 and 8xx
Next by Date: [RFC V1 01/31] mm/debug_vm_pgtable: Directly use vm_get_page_prot()
Previous by thread: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init()
Next by thread: Re: [PATCH 1/7] modules: Refactor within_module_core() and within_module_init()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]