On Thu, Dec 23, 2021 at 03:24:21PM +0000, David Howells wrote:
> > > + while (offset < folio_size(folio)) { \
> >
> > Nit: I'd be tempted to use a for loop on offset here.
>
> A while-loop makes more sense here. The adjustment you need for offset
> (ie. len) is overwritten after offset is altered at the end of the loop:
>
> > + offset += len; \
> > + len = PAGE_SIZE; \
> > } \
>
> So you'd have to move both of these into the for-incrementor expression, in
> addition to moving in the initialiser expression, making the thing less
> readable.
Ok.
