> + size_t offset = offset_in_folio(folio, start + __off); \ > + if (xas_retry(&xas, folio)) \ > continue; \ > + if (WARN_ON(xa_is_value(folio))) \ > break; \ > + if (WARN_ON(folio_test_hugetlb(folio))) \ > break; \ > + while (offset < folio_size(folio)) { \ Nit: I'd be tempted to use a for loop on offset here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>