Re: [PATCH] vmalloc: remove #ifdef in function body

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 21 Dec 2011 07:32:36 +0100, Joe Perches <joe@xxxxxxxxxxx> wrote:

On Wed, 2011-12-21 at 07:21 +0100, Michal Nazarewicz wrote:
it seems the community prefers
having ifdefs outside of the function.

Some do, some don't.

http://comments.gmane.org/gmane.linux.network/214543

This patch that you pointed to is against “#ifdefs are ugly” style
described in Documentation/SubmittingPatches.

If it's not in coding style, I suggest
it should be changed if it doesn't
add some other useful value.

That my be true.  I guess no one took time to adding it to the document.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]