On Wed, 2011-12-21 at 14:45 +0900, Minchan Kim wrote: > On Tue, Dec 20, 2011 at 09:31:21PM -0800, Joe Perches wrote: > > On Wed, 2011-12-21 at 14:17 +0900, Minchan Kim wrote: > > > We don't like function body which include #ifdef. [] > > I don't like this change. > > I think it's perfectly good style to use: > I feel it's no problem as it is because it's very short function now > but it's not style we prefer. Who is this "we" you refer to? There's nothing suggesting your patch as a preferred style in Documentation/CodingStyle. cheers, Joe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>