On Mon, Dec 19, 2011 at 11:45:22AM +0000, Mel Gorman wrote: > On Sun, Dec 18, 2011 at 11:05:52AM +0900, Minchan Kim wrote: > > On Wed, Dec 14, 2011 at 03:41:30PM +0000, Mel Gorman wrote: > > > This patch adds a lightweight sync migrate operation MIGRATE_SYNC_LIGHT > > > mode that avoids writing back pages to backing storage. Async > > > compaction maps to MIGRATE_ASYNC while sync compaction maps to > > > MIGRATE_SYNC_LIGHT. For other migrate_pages users such as memory > > > hotplug, MIGRATE_SYNC is used. > > > > > > This avoids sync compaction stalling for an excessive length of time, > > > particularly when copying files to a USB stick where there might be > > > a large number of dirty pages backed by a filesystem that does not > > > support ->writepages. > > > > > > [aarcange@xxxxxxxxxx: This patch is heavily based on Andrea's work] > > > Signed-off-by: Mel Gorman <mgorman@xxxxxxx> > > > > Acked-by: Minchan Kim <minchan@xxxxxxxxxx> > > > > Thanks. > > > > <SNIP> > > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > > > index 10b9883..6b80537 100644 > > > --- a/fs/hugetlbfs/inode.c > > > +++ b/fs/hugetlbfs/inode.c > > > @@ -577,7 +577,7 @@ static int hugetlbfs_set_page_dirty(struct page *page) > > > > > > static int hugetlbfs_migrate_page(struct address_space *mapping, > > > struct page *newpage, struct page *page, > > > - bool sync) > > > + enum migrate_mode mode) > > > > Nitpick, except this one, we use enum migrate_mode sync. > > > > Actually, in all the core code, I used "mode" but I was inconsistent in > the headers and some of the filesystems. I should have converted all use > of "sync" which was a boolean to a mode which has three possible values > after this patch. > > ==== CUT HERE ==== > mm: compaction: Introduce sync-light migration for use by compaction fix > > Consistently name enum migrate_mode parameters "mode" instead of "sync". > > Signed-off-by: Mel Gorman <mgorman@xxxxxxx> Acked-by: Minchan Kim <minchan@xxxxxxxxxx> Thanks. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>